[Memoization 11/13] Make resource versions optional, even when resources are provided.
ClosedPublic
Actions

Authored by • cdecarolis on Aug 10 2021, 8:35 PM.

Details

Reviewers

• sandyryza
alangenfeld

Commits

R1:56805e316e7a: [Memoization 11/13] Make resource versions optional, even when resources are…

Summary

Title.

Test Plan

added additional test to ensure memoization occurs when resource version is None.

Diff Detail

Repository

R1 dagster

Branch

make_resource_version_optional

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

• cdecarolis created this revision.Aug 10 2021, 8:35 PM

• cdecarolis retitled this revision from [Memoization 11/n] Make resource versions optional, even when resources are provided. to [Memoization 11/12] Make resource versions optional, even when resources are provided..Aug 10 2021, 8:37 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 10 2021, 8:58 PM

Harbormaster failed remote builds in B34638: Diff 42852!

Harbormaster completed remote builds in B34639: Diff 42853.Aug 10 2021, 9:44 PM

• cdecarolis requested review of this revision.Aug 10 2021, 9:44 PM

• cdecarolis retitled this revision from [Memoization 11/12] Make resource versions optional, even when resources are provided. to [Memoization 11/13] Make resource versions optional, even when resources are provided..Aug 11 2021, 12:20 AM

I think the asymettery between solids and resources and their memoization behavior is unfortunate, but as long as its clearly communicated it should be fine

This revision is now accepted and ready to land.Aug 12 2021, 7:29 PM

Closed by commit R1:56805e316e7a: [Memoization 11/13] Make resource versions optional, even when resources are… (authored by Chris DeCarolis <cdguitar817@gmail.com>). · Explain WhyAug 16 2021, 5:46 PM

This revision was automatically updated to reflect the committed changes.

Chris DeCarolis <cdguitar817@gmail.com> added a commit: R1:56805e316e7a: [Memoization 11/13] Make resource versions optional, even when resources are….