Page MenuHomeElementl

[dagit] Extract ContentRoot to be an App child
ClosedPublic

Authored by dish on Aug 9 2021, 4:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 10, 6:59 AM
Unknown Object (File)
Tue, May 9, 11:47 AM
Unknown Object (File)
Apr 25 2023, 6:17 AM
Unknown Object (File)
Apr 22 2023, 8:57 AM
Unknown Object (File)
Apr 16 2023, 11:53 AM
Unknown Object (File)
Apr 14 2023, 10:40 PM
Unknown Object (File)
Apr 10 2023, 9:26 AM
Unknown Object (File)
Mar 25 2023, 9:00 PM
Subscribers
None

Details

Summary

Provide ContentRoot from the index level. This allows better customization of the route tree.

I had considered making route configuration more abstract (and even landed some code for it) but it's just not worth introducing that level of complexity yet, and there are more pressing needs that this helps with.

Test Plan

Run Dagit, verify that workspace, instance, and settings routes all work correctly.

Diff Detail

Repository
R1 dagster
Branch
dish-app-routes
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

This is so that the cloud index can add cloud-specific routes?

This revision is now accepted and ready to land.Aug 9 2021, 4:36 PM

This is so that the cloud index can add cloud-specific routes?

Correct.