Page MenuHomeElementl

[dagit] Extract ContentRoot to be an App child
ClosedPublic

Authored by dish on Aug 9 2021, 4:18 PM.

Details

Summary

Provide ContentRoot from the index level. This allows better customization of the route tree.

I had considered making route configuration more abstract (and even landed some code for it) but it's just not worth introducing that level of complexity yet, and there are more pressing needs that this helps with.

Test Plan

Run Dagit, verify that workspace, instance, and settings routes all work correctly.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish requested review of this revision.Aug 9 2021, 4:28 PM

This is so that the cloud index can add cloud-specific routes?

This revision is now accepted and ready to land.Aug 9 2021, 4:36 PM

This is so that the cloud index can add cloud-specific routes?

Correct.

This revision was automatically updated to reflect the committed changes.