Differential D9204

[memoization 6/n] Add validation to version strings for memoization
ClosedPublic
Actions

Authored by • cdecarolis on Aug 4 2021, 3:09 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Aug 13, 10:35 PM

	Unknown Object (File)
	Fri, Aug 12, 4:40 PM

	Unknown Object (File)
	Fri, Aug 12, 4:40 PM

	Unknown Object (File)
	Thu, Aug 11, 5:44 AM

	Unknown Object (File)
	Sun, Aug 7, 10:12 AM

	Unknown Object (File)
	Fri, Aug 5, 1:54 AM

	Unknown Object (File)
	Thu, Jul 28, 5:06 AM

	Unknown Object (File)
	Wed, Jul 27, 11:30 PM

View All 40 Files

Subscribers

None

Details

Reviewers

alangenfeld
• sandyryza

Commits

R1:791c2fd66add: [memoization 6/n] Add validation to version strings for memoization

Summary

There was previously no validation applied to version strings, which are technically user code. Since these can end up being on a storage path, it is important that they are secured.

Test Plan

added tests to ensure errors when versions don't match regex.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• cdecarolis created this revision.Aug 4 2021, 3:09 AM

• cdecarolis mentioned this in D9085: [memoization 8/n] make default fs io manager memoizable.Aug 4 2021, 3:11 AM

• cdecarolis retitled this revision from Add validation to version strings for memoization to [memoization 6/n] Add validation to version strings for memoization.

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 4 2021, 3:30 AM

Harbormaster failed remote builds in B34599: Diff 42792!

Up

Harbormaster completed remote builds in B34603: Diff 42799.Aug 4 2021, 4:57 PM

• cdecarolis requested review of this revision.Aug 4 2021, 4:57 PM

• sandyryza accepted this revision.Aug 9 2021, 6:38 PM

This revision is now accepted and ready to land.Aug 9 2021, 6:38 PM

Closed by commit R1:791c2fd66add: [memoization 6/n] Add validation to version strings for memoization (authored by Chris DeCarolis <cdguitar817@gmail.com>). · Explain WhyAug 9 2021, 10:04 PM

This revision was automatically updated to reflect the committed changes.

Chris DeCarolis <cdguitar817@gmail.com> added a commit: R1:791c2fd66add: [memoization 6/n] Add validation to version strings for memoization.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

dagster/

core/

execution/

plan/

12 lines

resolve_versions.py

18 lines

dagster_tests/

core_tests/

test_resolve_versions.py

94 lines

Diff 42838

python_modules/dagster/dagster/core/execution/plan/inputs.py

Loading...

python_modules/dagster/dagster/core/execution/resolve_versions.py

Loading...

python_modules/dagster/dagster_tests/core_tests/test_resolve_versions.py

Loading...