[memoization 6/n] Add validation to version strings for memoization
ClosedPublic
Actions

Authored by cdecarolis on Aug 4 2021, 3:09 AM.

Details

Reviewers

alangenfeld
sandyryza

Commits

R1:791c2fd66add: [memoization 6/n] Add validation to version strings for memoization

Summary

There was previously no validation applied to version strings, which are technically user code. Since these can end up being on a storage path, it is important that they are secured.

Test Plan

added tests to ensure errors when versions don't match regex.

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cdecarolis created this revision.Aug 4 2021, 3:09 AM

cdecarolis mentioned this in D9085: [memoization 8/n] make default fs io manager memoizable.Aug 4 2021, 3:11 AM

cdecarolis retitled this revision from Add validation to version strings for memoization to [memoization 6/n] Add validation to version strings for memoization.

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 4 2021, 3:30 AM

Harbormaster failed remote builds in B34599: Diff 42792!