Page MenuHomeElementl

Dockerfile/deployment instructions for deploying hacker-news to k8s
ClosedPublic

Authored by dgibson on Aug 4 2021, 2:48 AM.

Details

Summary

This augments the hacker-news instructions to include how one would actually deploy it to k8s. I have not gone through them myself yet and I imagine some tweaks and extra steps will emerge when I do, but I wanted to see if this is what you were imagining, sandy.

Test Plan

follow these instructions myself in a free k8s cluster

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dgibson published this revision for review.Aug 4 2021, 2:49 AM
dgibson added inline comments.
examples/hacker_news/Dockerfile
4โ€“19

i'm not positive that these are needed, i copied them blindly from our CI/CD dockerfile

examples/hacker_news/README.md
48

this is based on the env vars that are set in our CI/CD dockerfile

Thanks a ton for putting this together @dgibson!

examples/hacker_news/Dockerfile
4โ€“19

We can take this out - the demo pipelines no longer write to GCS.

21

It could be helpful to include some comments explaining what's going on in these last two lines. Why are we doing the COPY? Does pip install -e . work because we're running this from inside the directory that includes the setup.py for the hackernews project?

examples/hacker_news/README.md
53

Tested it out and this works!

update after succesfully running

dgibson retitled this revision from WIP: Dockerfile/deployment instructions for deploying hacker-news to k8s to Dockerfile/deployment instructions for deploying hacker-news to k8s.Thu, Aug 19, 8:04 PM

LGTM! Thanks for working on this @dgibson .

This revision is now accepted and ready to land.Fri, Aug 20, 5:09 PM
This revision was landed with ongoing or failed builds.Fri, Aug 20, 7:08 PM
This revision was automatically updated to reflect the committed changes.