Page MenuHomeElementl
Differential D9196

[dagit] Perms followup
ClosedPublic
Actions

Authored by • dish on Aug 3 2021, 4:19 PM.
Tags
None
Referenced Files
F2561157: D9196.diff
Sat, Sep 24, 6:23 PM
Unknown Object (File)
Sun, Sep 11, 3:03 PM
Unknown Object (File)
Sun, Sep 11, 2:18 AM
Unknown Object (File)
Wed, Sep 7, 8:26 AM
Unknown Object (File)
Aug 12 2022, 4:35 PM
Unknown Object (File)
Aug 12 2022, 4:34 PM
Unknown Object (File)
Aug 12 2022, 2:53 AM
Unknown Object (File)
Aug 11 2022, 11:34 AM
View All 47 Files
Subscribers
None

Details

Reviewers
• dgibson
Commits
R1:4694cc873bd5: [dagit] Perms followup
Summary

Make a handful of changes that will make it simpler to integrate permissions with the internal repo.

Test Plan

Buildkite, load Dagit and sanity check behavior of permissions.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• dish created this revision.Aug 3 2021, 4:19 PM
Harbormaster completed remote builds in B34583: Diff 42768.Aug 3 2021, 4:30 PM
• dish requested review of this revision.Aug 3 2021, 4:30 PM
• dgibson accepted this revision.Aug 3 2021, 4:32 PM
This revision is now accepted and ready to land.Aug 3 2021, 4:32 PM
Closed by commit R1:4694cc873bd5: [dagit] Perms followup (authored by • dish). · Explain WhyAug 3 2021, 4:37 PM
This revision was automatically updated to reflect the committed changes.
• dish added a commit: R1:4694cc873bd5: [dagit] Perms followup.

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
packages/
core/
src/
app/
41 lines
2 lines
pipelines/
2 lines
testing/
42 lines

Diff 42770

View Options

js_modules/dagit/packages/core/src/app/Permissions.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/app/Switch.test.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/pipelines/PipelineRoot.test.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/testing/TestProvider.tsx

Loading...