Page MenuHomeElementl
Differential D9195

add composite solids to graph/job/op migration guide
ClosedPublic
Actions

Authored by • sandyryza on Aug 3 2021, 4:06 PM.

Details

Reviewers
• cdecarolis
alangenfeld
Commits
R1:5b279196a578: add composite solids to graph/job/op migration guide
Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• sandyryza updated this revision to Diff 42766.Aug 3 2021, 4:06 PM
• sandyryza created this revision.

up

Harbormaster failed remote builds in B34580: Diff 42765!Aug 3 2021, 4:31 PM
Harbormaster completed remote builds in B34581: Diff 42766.Aug 3 2021, 4:33 PM
• sandyryza requested review of this revision.Aug 3 2021, 4:33 PM
alangenfeld requested changes to this revision.Aug 4 2021, 2:45 PM

I think its very valuable for this example to include input & output mapping

related: should we change @graph to ins out ?

This revision now requires changes to proceed.Aug 4 2021, 2:45 PM
• sandyryza updated this revision to Diff 42800.Aug 4 2021, 4:40 PM

up

Harbormaster failed remote builds in B34604: Diff 42800!Aug 4 2021, 5:02 PM
• sandyryza updated this revision to Diff 42803.Aug 4 2021, 6:14 PM

up

Harbormaster completed remote builds in B34605: Diff 42803.Aug 4 2021, 6:38 PM
• sandyryza added inline comments.Aug 4 2021, 7:01 PM
examples/docs_snippets/docs_snippets/guides/dagster/graph_job_op/nested_graphs.py
2

1.

• sandyryza added a comment.Aug 4 2021, 7:02 PM

@alangenfeld good point - I updated to give the graphs inputs and outputs

alangenfeld accepted this revision.Aug 4 2021, 7:15 PM

limecat

This revision is now accepted and ready to land.Aug 4 2021, 7:15 PM
Closed by commit R1:5b279196a578: add composite solids to graph/job/op migration guide (authored by • sandyryza). · Explain WhyAug 4 2021, 11:44 PM
This revision was automatically updated to reflect the committed changes.
• sandyryza added a commit: R1:5b279196a578: add composite solids to graph/job/op migration guide.

Revision Contents
Changeset List

PathSize
docs/
content/
guides/
dagster/
66 lines
examples/
docs_snippets/
docs_snippets/
guides/
dagster/
graph_job_op/
27 lines
27 lines
docs_snippets_tests/
guides_tests/
graph_job_op_tests/
4 lines

Diff 42807

View Options

docs/content/guides/dagster/graph_job_op.mdx

Loading...
View Options

examples/docs_snippets/docs_snippets/guides/dagster/graph_job_op/composite_solid.py

Loading...
View Options

examples/docs_snippets/docs_snippets/guides/dagster/graph_job_op/nested_graphs.py

Loading...
View Options

examples/docs_snippets/docs_snippets_tests/guides_tests/graph_job_op_tests/test_graph_job_op_examples.py

Loading...