Page MenuHomeElementl
Differential D9191

test execute_in_process with aliasing
ClosedPublic
Actions

Authored by cdecarolis on Aug 3 2021, 12:04 AM.

Details

Reviewers
alangenfeld
Commits
R1:b62f21143645: test execute_in_process with aliasing
Summary

Realized this wasn't really covered. There's probably more test cases that we should add, gonna try and audit that.

Test Plan

unit tests

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cdecarolis created this revision.Aug 3 2021, 12:04 AM
Harbormaster completed remote builds in B34573: Diff 42754.Aug 3 2021, 12:29 AM
cdecarolis requested review of this revision.Aug 3 2021, 12:29 AM
alangenfeld accepted this revision.Aug 3 2021, 3:01 PM
alangenfeld added inline comments.
python_modules/dagster/dagster_tests/core_tests/graph_tests/test_graph.py
27–41

instead of editing in place - can you just add a new test case and leave the simpler one alone? I think having the basic ones is useful for triangulating failures

This revision is now accepted and ready to land.Aug 3 2021, 3:01 PM
Closed by commit R1:b62f21143645: test execute_in_process with aliasing (authored by Chris DeCarolis <cdguitar817@gmail.com>). · Explain WhyAug 3 2021, 11:11 PM
This revision was automatically updated to reflect the committed changes.
Chris DeCarolis <cdguitar817@gmail.com> added a commit: R1:b62f21143645: test execute_in_process with aliasing.

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster_tests/
core_tests/
graph_tests/
22 lines

Diff 42787

View Options

python_modules/dagster/dagster_tests/core_tests/graph_tests/test_graph.py

Loading...