Differential D9191

test execute_in_process with aliasing
ClosedPublic
Actions

Authored by • cdecarolis on Aug 3 2021, 12:04 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jan 21, 8:58 PM

	Unknown Object (File)
	Sun, Jan 8, 10:42 AM

	Unknown Object (File)
	Dec 17 2022, 10:39 AM

	Unknown Object (File)
	Dec 13 2022, 10:45 PM

	Unknown Object (File)
	Nov 19 2022, 6:10 PM

	Unknown Object (File)
	Nov 15 2022, 3:34 PM

	Unknown Object (File)
	Nov 14 2022, 11:04 PM

	Unknown Object (File)
	Nov 14 2022, 11:03 PM

View All 57 Files

Subscribers

None

Details

Reviewers

Commits

R1:b62f21143645: test execute_in_process with aliasing

Summary

Realized this wasn't really covered. There's probably more test cases that we should add, gonna try and audit that.

Test Plan

unit tests

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• cdecarolis created this revision.Aug 3 2021, 12:04 AM

Harbormaster completed remote builds in B34573: Diff 42754.Aug 3 2021, 12:29 AM

• cdecarolis requested review of this revision.Aug 3 2021, 12:29 AM

alangenfeld accepted this revision.Aug 3 2021, 3:01 PM

alangenfeld added inline comments.

python_modules/dagster/dagster_tests/core_tests/graph_tests/test_graph.py
27–41	instead of editing in place - can you just add a new test case and leave the simpler one alone? I think having the basic ones is useful for triangulating failures

This revision is now accepted and ready to land.Aug 3 2021, 3:01 PM

Closed by commit R1:b62f21143645: test execute_in_process with aliasing (authored by Chris DeCarolis <cdguitar817@gmail.com>). · Explain WhyAug 3 2021, 11:11 PM

This revision was automatically updated to reflect the committed changes.

Chris DeCarolis <cdguitar817@gmail.com> added a commit: R1:b62f21143645: test execute_in_process with aliasing.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

dagster_tests/

core_tests/

graph_tests/

22 lines

Diff 42787

python_modules/dagster/dagster_tests/core_tests/graph_tests/test_graph.py

Loading...