Page MenuHomeElementl

[crag] Add validation step to default config buildup for to_job.
ClosedPublic

Authored by cdecarolis on Aug 2 2021, 11:10 PM.

Details

Summary

We previously weren't doing any validation of config in to_job. This adds validation, and also carries over all fields from old config document.

Test Plan

added unit test to ensure config mistakes are caught.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cdecarolis retitled this revision from Add validation step to default config buildup for to_job. to [crag] Add validation step to default config buildup for to_job..Aug 3 2021, 12:12 AM
alangenfeld added inline comments.
python_modules/dagster/dagster/core/definitions/graph.py
795–797

I think we can do better with this pre-amble

  • make sure to align with the name of the arg - drop "default" i think
  • mention the job name / graph name, maybe both since is the a failure in the process of creating the job from the graph
This revision is now accepted and ready to land.Aug 3 2021, 2:56 PM