Page MenuHomeElementl
Differential D9187

[crag] use non-Nothing inputs in crag toys
ClosedPublic
Actions

Authored by • sandyryza on Aug 2 2021, 9:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 19, 3:15 PM
Unknown Object (File)
Mon, Nov 14, 10:58 PM
Unknown Object (File)
Mon, Nov 14, 10:58 PM
Unknown Object (File)
Mon, Nov 14, 10:57 PM
Unknown Object (File)
Sat, Nov 12, 3:08 PM
Unknown Object (File)
Nov 7 2022, 10:07 PM
Unknown Object (File)
Nov 3 2022, 4:06 AM
Unknown Object (File)
Nov 1 2022, 11:06 PM
View All 59 Files
Subscribers
None

Details

Reviewers
• bengotow
• cdecarolis
Commits
R1:d68613f25f68: [crag] use non-Nothing inputs in crag toys
Summary

Ben found the everywhere-Nothing inputs a little confusing, and I separately had to provide non-Nothing inputs to reproduce a user issue with to_job and the default IO manager.

Test Plan

bk, run the event_tables job in local dagit

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• sandyryza created this revision.Aug 2 2021, 9:33 PM
Harbormaster completed remote builds in B34562: Diff 42740.Aug 2 2021, 9:55 PM
• sandyryza requested review of this revision.Aug 2 2021, 9:55 PM
• sandyryza added reviewers: • bengotow, • cdecarolis.Aug 2 2021, 10:26 PM
• sandyryza retitled this revision from use non-Nothing inputs in crag toys to [crag] use non-Nothing inputs in crag toys.Aug 3 2021, 4:10 PM
• bengotow accepted this revision.Aug 4 2021, 3:13 PM

Thanks for following up on this one! Does this mean that unlinked inputs would generally make sense to display in an accent color now? (re: https://github.com/dagster-io/dagster/issues/4407)

This revision is now accepted and ready to land.Aug 4 2021, 3:13 PM
Closed by commit R1:d68613f25f68: [crag] use non-Nothing inputs in crag toys (authored by • sandyryza). · Explain WhyAug 9 2021, 4:03 PM
This revision was automatically updated to reflect the committed changes.
• sandyryza added a commit: R1:d68613f25f68: [crag] use non-Nothing inputs in crag toys.
• sandyryza added a comment.Aug 9 2021, 4:05 PM

Does this mean that unlinked inputs would generally make sense to display in an accent color now? (re: https://github.com/dagster-io/dagster/issues/4407)

Hmm, I guess it's an aesthetics question that I don't know if I have a useful opinion on. Open to either direction. I think my instinct would be not to have an accent color, because the fact that there's no line going into it would be enough to visually distinguish it.

Revision Contents
Changeset List

PathSize
python_modules/
dagster-test/
dagster_test/
toys/
14 lines

Diff 42827

View Options

python_modules/dagster-test/dagster_test/toys/graph_job_repos.py

Loading...