Page MenuHomeElementl

[crag] use non-Nothing inputs in crag toys
ClosedPublic

Authored by sandyryza on Aug 2 2021, 9:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 27, 11:36 AM
Unknown Object (File)
Fri, Jun 24, 7:12 PM
Unknown Object (File)
Wed, Jun 22, 2:09 PM
Unknown Object (File)
Tue, Jun 21, 5:02 PM
Unknown Object (File)
Tue, Jun 21, 5:02 PM
Unknown Object (File)
Tue, Jun 21, 5:02 PM
Unknown Object (File)
Sat, Jun 18, 11:15 AM
Unknown Object (File)
Sat, Jun 18, 9:00 AM
Subscribers
None

Details

Summary

Ben found the everywhere-Nothing inputs a little confusing, and I separately had to provide non-Nothing inputs to reproduce a user issue with to_job and the default IO manager.

Test Plan

bk, run the event_tables job in local dagit

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sandyryza retitled this revision from use non-Nothing inputs in crag toys to [crag] use non-Nothing inputs in crag toys.Aug 3 2021, 4:10 PM

Thanks for following up on this one! Does this mean that unlinked inputs would generally make sense to display in an accent color now? (re: https://github.com/dagster-io/dagster/issues/4407)

This revision is now accepted and ready to land.Aug 4 2021, 3:13 PM

Does this mean that unlinked inputs would generally make sense to display in an accent color now? (re: https://github.com/dagster-io/dagster/issues/4407)

Hmm, I guess it's an aesthetics question that I don't know if I have a useful opinion on. Open to either direction. I think my instinct would be not to have an accent color, because the fact that there's no line going into it would be enough to visually distinguish it.