Page MenuHomeElementl

[dagit] Add Permissions query
ClosedPublic

Authored by dish on Aug 2 2021, 8:34 PM.

Details

Summary

Create a PermissionsProvider that queries for permissions via GraphQL, as arranged in https://dagster.phacility.com/D9122.

Test Plan

Load Dagit, verify that permissions are queried and used properly.

Diff Detail

Repository
R1 dagster
Branch
dish-perms
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 2 2021, 8:56 PM
Harbormaster failed remote builds in B34558: Diff 42736!
dish requested review of this revision.Aug 2 2021, 9:46 PM

this looks good, one big thing that was missing from the diff this is patched on is python tests though - I may be able to tackle that this morning, given that permissions are fairly sensitive i think its important to have some coverage there

Does this require any changes in the internal repo in order to avoid any breaking changes there?

tests in https://dagster.phacility.com/D9193 - lets make sure we have a change ready for internal though if this is breaking there

This revision is now accepted and ready to land.Aug 3 2021, 1:19 PM

Compatibility, expose raw permission array.

Does this require any changes in the internal repo in order to avoid any breaking changes there?

Verdict is: yes. Will have a followup.

This revision was automatically updated to reflect the committed changes.