Carry over field aliases to default config for job
ClosedPublic
Actions

Authored by cdecarolis on Jul 31 2021, 6:45 PM.

Details

Reviewers

sandyryza
alangenfeld

Commits

R1:3751d986cf70: Carry over field aliases to default config for job

Summary

Fix for https://github.com/dagster-io/dagster/issues/4422. Default config schema previously dropped config aliases, so playground config would break.

Test Plan

added a unit test to ensure that switching between ops/solids config from execute_in_process works as intended

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cdecarolis created this revision.Jul 31 2021, 6:45 PM

cdecarolis edited the summary of this revision. (Show Details)Jul 31 2021, 6:46 PM

Harbormaster completed remote builds in B34525: Diff 42690.Jul 31 2021, 7:28 PM

cdecarolis requested review of this revision.Jul 31 2021, 7:28 PM

alangenfeld accepted this revision.Aug 2 2021, 1:59 PM

This revision is now accepted and ready to land.Aug 2 2021, 1:59 PM

Closed by commit R1:3751d986cf70: Carry over field aliases to default config for job (authored by Chris DeCarolis <cdguitar817@gmail.com>). · Explain WhyAug 2 2021, 5:31 PM

This revision was automatically updated to reflect the committed changes.

Chris DeCarolis <cdguitar817@gmail.com> added a commit: R1:3751d986cf70: Carry over field aliases to default config for job.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

core/

definitions/

graph.py

1 line

dagster_tests/

core_tests/

graph_tests/

test_graph.py

21 lines

Diff 42730

View Options

python_modules/dagster/dagster/core/definitions/graph.py