Page MenuHomeElementl

[crag] remove job arg from partitioned schedule decorators
ClosedPublic

Authored by sandyryza on Jul 30 2021, 11:31 PM.

Details

Summary

The graph/job/op of supporting partitioned schedules is through PartitionedConfig

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 31 2021, 12:14 AM
Harbormaster failed remote builds in B34517: Diff 42681!
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 2 2021, 4:09 PM
Harbormaster failed remote builds in B34551: Diff 42722!
sandyryza retitled this revision from remove job arg from partitioned schedule decorators to [crag] remove job arg from partitioned schedule decorators.Aug 2 2021, 8:21 PM

See comment

python_modules/dagster/dagster/core/definitions/decorators/schedule.py
79

Is this intentional? Looks like it doesn't match the funcsig

This revision is now accepted and ready to land.Aug 2 2021, 9:18 PM
python_modules/dagster/dagster/core/definitions/decorators/schedule.py
79

yeah - arguably should be its own diff, but was a small related change. I think it does match the funcsig.