Page MenuHomeElementl

[crag] allow non-string tag values in to_job
ClosedPublic

Authored by sandyryza on Jul 30 2021, 10:26 PM.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 30 2021, 11:08 PM
Harbormaster failed remote builds in B34516: Diff 42679!

add tests for valid non-str tag and invalid non-str tag

python_modules/dagster/dagster/core/definitions/graph.py
415

theres a fn validate_tags that should get called eventually, may already be lower in the stack

This revision is now accepted and ready to land.Aug 2 2021, 2:01 PM
sandyryza retitled this revision from allow non-string tag values in to_job to [crag] allow non-string tag values in to_job.Aug 2 2021, 8:23 PM