[crag] allow non-string tag values in to_job
ClosedPublic
Actions

Authored by sandyryza on Jul 30 2021, 10:26 PM.

Details

Reviewers

cdecarolis
alangenfeld

Commits

R1:1f936709ec27: [crag] allow non-string tag values in to_job

Test Plan

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sandyryza created this revision.Jul 30 2021, 10:26 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 30 2021, 11:08 PM

Harbormaster failed remote builds in B34516: Diff 42679!

Harbormaster completed remote builds in B34524: Diff 42689.Jul 31 2021, 5:32 PM

sandyryza requested review of this revision.Jul 31 2021, 5:32 PM

add tests for valid non-str tag and invalid non-str tag

python_modules/dagster/dagster/core/definitions/graph.py
415	theres a fn `validate_tags` that should get called eventually, may already be lower in the stack

This revision is now accepted and ready to land.Aug 2 2021, 2:01 PM

Harbormaster completed remote builds in B34548: Diff 42719.Aug 2 2021, 4:04 PM

sandyryza retitled this revision from allow non-string tag values in to_job to [crag] allow non-string tag values in to_job.Aug 2 2021, 8:23 PM

Closed by commit R1:1f936709ec27: [crag] allow non-string tag values in to_job (authored by sandyryza). · Explain WhyAug 2 2021, 8:25 PM

This revision was automatically updated to reflect the committed changes.

sandyryza added a commit: R1:1f936709ec27: [crag] allow non-string tag values in to_job.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

core/

definitions/

graph.py

4 lines

dagster_tests/

core_tests/

graph_tests/

test_graph.py

20 lines

Diff 42735

View Options

python_modules/dagster/dagster/core/definitions/graph.py