Page MenuHomeElementl
Differential D9170

[dagit] Stop overfetching schedule/sensor in JobMetadata
ClosedPublic
Actions

Authored by • dish on Jul 30 2021, 10:01 PM.
Tags
None
Referenced Files
F2560696: D9170.diff
Sat, Sep 24, 11:08 AM
Unknown Object (File)
Tue, Sep 13, 9:38 AM
Unknown Object (File)
Tue, Sep 13, 9:38 AM
Unknown Object (File)
Tue, Sep 13, 9:38 AM
Unknown Object (File)
Tue, Sep 13, 9:38 AM
Unknown Object (File)
Tue, Sep 13, 9:38 AM
Unknown Object (File)
Wed, Sep 7, 5:19 PM
Unknown Object (File)
Wed, Sep 7, 4:12 AM
View All 35 Files
Subscribers
None

Details

Reviewers
• bengotow
• prha
• sandyryza
Commits
R1:e93b23ef47e9: [dagit] Stop overfetching schedule/sensor in JobMetadata
Summary

I noticed that the schedule and sensor fragments used in JobMetadata are overfetching considerably. Give the switch components their own fragments, since that's all we really need in this circumstance.

Test Plan

View jobs that have schedules and sensors. Verify that they no longer overfetch.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
packages/
core/
src/
nav/
16 lines
types/
schedules/
17 lines
types/
sensors/
18 lines
types/

Diff 42712

View Options

js_modules/dagit/packages/core/src/nav/JobMetadata.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/nav/types/JobMetadataQuery.ts

Loading...
View Options

js_modules/dagit/packages/core/src/schedules/ScheduleSwitch.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/schedules/types/ScheduleSwitchFragment.ts

Loading...
View Options

js_modules/dagit/packages/core/src/sensors/SensorSwitch.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/sensors/types/SensorSwitchFragment.ts

Loading...