Page MenuHomeElementl
Differential D9142

feat(helm): configure environment variables for K8sRunLauncher
ClosedPublic
Actions

Authored by rexledesma on Jul 29 2021, 2:18 PM.

Details

Reviewers
dgibson
johann
Commits
R1:f55728d283cb: feat(helm): configure environment variables for K8sRunLauncher
Summary

Depends on D9140.

Test Plan

pytest
integration

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rexledesma created this revision.Jul 29 2021, 2:18 PM
rexledesma updated this revision to Diff 42572.Jul 29 2021, 2:31 PM

up

rexledesma published this revision for review.Jul 29 2021, 2:31 PM
dgibson accepted this revision.Jul 29 2021, 2:33 PM

optionally something in the run launcher integration test that makes use of the env_vars field would be nice for e2e coverage, but we do have integration tests on the various pieces so that seems pretty good

This revision is now accepted and ready to land.Jul 29 2021, 2:33 PM
rexledesma updated this revision to Diff 42578.Jul 29 2021, 3:01 PM

up

Harbormaster completed remote builds in B34443: Diff 42572.Jul 29 2021, 3:17 PM
This revision was landed with ongoing or failed builds.Jul 29 2021, 3:26 PM
Closed by commit R1:f55728d283cb: feat(helm): configure environment variables for K8sRunLauncher (authored by rexledesma). · Explain Why
This revision was automatically updated to reflect the committed changes.
rexledesma added a commit: R1:f55728d283cb: feat(helm): configure environment variables for K8sRunLauncher.
Harbormaster failed remote builds in B34441: Diff 42570!Jul 29 2021, 3:44 PM
Harbormaster completed remote builds in B34448: Diff 42578.Jul 29 2021, 3:47 PM

Revision Contents
Changeset List

PathSize
helm/
dagster/
schema/
schema/
charts/
dagster/
subschema/
1 line
schema_tests/
44 lines
templates/
helpers/
instance/
4 lines
8 lines
integration_tests/
python_modules/
dagster-k8s-test-infra/
dagster_k8s_test_infra/
1 line

Diff 42584

View Options

helm/dagster/schema/schema/charts/dagster/subschema/run_launcher.py

Loading...
View Options

helm/dagster/schema/schema_tests/test_instance.py

Loading...
View Options

helm/dagster/templates/helpers/instance/_run-launcher.tpl

Loading...
View Options

helm/dagster/values.schema.json

Loading...
View Options

helm/dagster/values.yaml

Loading...
View Options

integration_tests/python_modules/dagster-k8s-test-infra/dagster_k8s_test_infra/helm.py

Loading...