Page MenuHomeElementl

Add custom serializer to config type snapshot
ClosedPublic

Authored by dgibson on Jul 29 2021, 2:06 PM.

Details

Summary

This makes the pipeline snapshot Id stable if you haven't made any changes to the run config.

Test Plan

BK, verify pipeline snapshot ID changes in https://dagster.phacility.com/D8550 no longer needed

Diff Detail

Repository
R1 dagster
Branch
stability (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 29 2021, 2:35 PM
Harbormaster failed remote builds in B34440: Diff 42569!
python_modules/dagster/dagster/serdes/serdes.py
138–173

empty set?

would be nice to add a serdes test case for this as well

173

nit: I really had to stare at this for a bit to convince my self this logic condition was correct, might be more legible if verbose or taken out of an inline dict creation

dgibson published this revision for review.Jul 29 2021, 2:48 PM

^ above comments worth considering

This revision is now accepted and ready to land.Jul 29 2021, 2:52 PM

add test case, make logic clearer

This revision was landed with ongoing or failed builds.Jul 29 2021, 3:25 PM
This revision was automatically updated to reflect the committed changes.