Page MenuHomeElementl
Differential D9140

feat: allow environment variables to be passed into K8sRunLauncher
ClosedPublic
Actions

Authored by • rexledesma on Jul 29 2021, 1:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 22, 9:54 AM
Unknown Object (File)
Tue, Jun 21, 4:53 PM
Unknown Object (File)
Tue, Jun 21, 4:53 PM
Unknown Object (File)
Tue, Jun 21, 4:53 PM
Unknown Object (File)
Mon, Jun 20, 4:37 AM
Unknown Object (File)
Sun, Jun 19, 5:04 PM
Unknown Object (File)
Sat, Jun 18, 8:51 AM
Unknown Object (File)
Fri, Jun 17, 1:31 PM
View All 13 Files
Subscribers
None

Details

Reviewers
• dgibson
• johann
Commits
R1:18bf9336cc33: feat: allow environment variables to be passed into K8sRunLauncher
Summary

Environment variables specified on the launcher are now passed into the
job configuration.

Test Plan

pytest

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• rexledesma created this revision.Jul 29 2021, 1:42 PM
Harbormaster completed remote builds in B34438: Diff 42567.Jul 29 2021, 2:08 PM
• rexledesma requested review of this revision.Jul 29 2021, 2:08 PM
• dgibson accepted this revision.Jul 29 2021, 2:10 PM

sweet, let's get this into the release today for hebo.

Separately, do we also want to make this available on the k8s job executor (delegating to the run launcher when none is specifically set, as in the other fields on https://dagster.phacility.com/D9078)

This revision is now accepted and ready to land.Jul 29 2021, 2:10 PM
• rexledesma added a child revision: D9142: feat(helm): configure environment variables for K8sRunLauncher.Jul 29 2021, 2:18 PM
Closed by commit R1:18bf9336cc33: feat: allow environment variables to be passed into K8sRunLauncher (authored by • rexledesma). · Explain WhyJul 29 2021, 3:26 PM
This revision was automatically updated to reflect the committed changes.
• rexledesma added a commit: R1:18bf9336cc33: feat: allow environment variables to be passed into K8sRunLauncher.

Revision Contents
Changeset List

PathSize
python_modules/
libraries/
dagster-k8s/
dagster_k8s/
25 lines
6 lines
dagster_k8s_tests/
unit_tests/
21 lines

Diff 42583

View Options

python_modules/libraries/dagster-k8s/dagster_k8s/job.py

Loading...
View Options

python_modules/libraries/dagster-k8s/dagster_k8s/launcher.py

Loading...
View Options

python_modules/libraries/dagster-k8s/dagster_k8s_tests/unit_tests/test_job.py

Loading...