Page MenuHomeElementl
Differential D9139

[mypy] definitions/events.py
ClosedPublic
Actions

Authored by • cdecarolis on Jul 29 2021, 1:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 9, 3:17 AM
Unknown Object (File)
Jan 2 2023, 2:14 AM
Unknown Object (File)
Dec 26 2022, 2:01 AM
Unknown Object (File)
Dec 13 2022, 10:33 PM
Unknown Object (File)
Nov 24 2022, 8:30 PM
Unknown Object (File)
Nov 19 2022, 5:42 PM
Unknown Object (File)
Nov 16 2022, 12:41 AM
Unknown Object (File)
Nov 14 2022, 10:06 PM
View All 83 Files
Subscribers
None

Details

Reviewers
alangenfeld
Commits
R1:4ef3b5d1784e: [mypy] definitions/events.py
Summary

Title. I feel like I had to do a few weird casts here that may point to some more underlying issues.

Test Plan

mypy

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• cdecarolis created this revision.Jul 29 2021, 1:59 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 29 2021, 2:41 AM
Harbormaster failed remote builds in B34431: Diff 42559!
• cdecarolis updated this revision to Diff 42669.Jul 30 2021, 7:50 PM

Up

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 30 2021, 8:55 PM
Harbormaster failed remote builds in B34508: Diff 42669!
• cdecarolis updated this revision to Diff 42752.Aug 2 2021, 11:58 PM

Up

• cdecarolis updated this revision to Diff 42753.Aug 2 2021, 11:59 PM

Up

Harbormaster completed remote builds in B34571: Diff 42752.Aug 3 2021, 12:21 AM
Harbormaster completed remote builds in B34572: Diff 42753.
• cdecarolis requested review of this revision.Aug 3 2021, 12:23 AM
alangenfeld accepted this revision.Aug 12 2021, 3:05 PM
This revision is now accepted and ready to land.Aug 12 2021, 3:05 PM
Closed by commit R1:4ef3b5d1784e: [mypy] definitions/events.py (authored by Chris DeCarolis <cdguitar817@gmail.com>). · Explain WhyAug 18 2021, 3:47 AM
This revision was automatically updated to reflect the committed changes.
Chris DeCarolis <cdguitar817@gmail.com> added a commit: R1:4ef3b5d1784e: [mypy] definitions/events.py.

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
core/
definitions/
66 lines
291 lines
events/
6 lines
execution/
plan/
10 lines

Diff 42902

View Options

python_modules/dagster/dagster/core/definitions/event_metadata.py

Loading...
View Options

python_modules/dagster/dagster/core/definitions/events.py

Loading...
View Options

python_modules/dagster/dagster/core/events/__init__.py

Loading...
View Options

python_modules/dagster/dagster/core/execution/plan/execute_step.py

Loading...