Make run storage test a bit less strict
AbandonedPublic
Actions

Authored by • dgibson on Jul 28 2021, 2:49 PM.

Tags

None

Referenced Files

	F2761386: D9120.diff
	Fri, Jan 27, 12:29 AM

	Unknown Object (File)
	Sun, Jan 1, 7:51 PM

	Unknown Object (File)
	Dec 13 2022, 10:31 PM

	Unknown Object (File)
	Nov 19 2022, 5:43 PM

	Unknown Object (File)
	Nov 14 2022, 9:56 PM

	Unknown Object (File)
	Nov 14 2022, 9:55 PM

	Unknown Object (File)
	Nov 12 2022, 2:26 PM

	Unknown Object (File)
	Nov 7 2022, 10:18 PM

Subscribers

None

Details

Reviewers

Summary

Test for a specific error message to encompass different types of run storage

Test Plan

Repository

R1 dagster

Branch

graphqlstorage (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

• dgibson published this revision for review.Jul 28 2021, 2:50 PM

• jordansanders added inline comments.

python_modules/dagster/dagster_tests/core_tests/storage_tests/utils/run_storage.py
900	Why are some run storage implementations raising an exception that doesn't inherit from DagsterRunNotFoundError? This feels like the test accurately describes behavior and we have implementations that should change.

This revision now requires changes to proceed.Jul 28 2021, 3:06 PM