Page MenuHomeElementl

Make run storage test a bit less strict
AbandonedPublic

Authored by dgibson on Jul 28 2021, 2:49 PM.
Tags
None
Referenced Files
F2304412: D9120.id.diff
Mon, Jul 4, 3:30 AM
Unknown Object (File)
Sun, Jul 3, 11:40 AM
Unknown Object (File)
Thu, Jun 30, 10:36 PM
Unknown Object (File)
Tue, Jun 28, 6:47 AM
Unknown Object (File)
Tue, Jun 21, 4:51 PM
Unknown Object (File)
Tue, Jun 21, 4:51 PM
Unknown Object (File)
Sat, Jun 18, 8:49 AM
Unknown Object (File)
Fri, Jun 17, 12:54 PM
Subscribers
None

Details

Summary

Test for a specific error message to encompass different types of run storage

Test Plan

BK

Diff Detail

Repository
R1 dagster
Branch
graphqlstorage (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

jordansanders added inline comments.
python_modules/dagster/dagster_tests/core_tests/storage_tests/utils/run_storage.py
900

Why are some run storage implementations raising an exception that doesn't inherit from DagsterRunNotFoundError? This feels like the test accurately describes behavior and we have implementations that should change.

This revision now requires changes to proceed.Jul 28 2021, 3:06 PM