Page MenuHomeElementl

[Easy] Adding serialization decorators & convenience methods
Needs RevisionPublic

Authored by sidkmenon on Jul 28 2021, 9:11 AM.

Details

Summary

Found that this was useful for an internal project

Test Plan

bk

Diff Detail

Repository
R1 dagster
Branch
audit-log (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Not sure if I'm allowed to mention in the commit message that this is for the audit log

sidkmenon added a child revision: Restricted Differential Revision.Jul 28 2021, 5:56 PM
sidkmenon added a child revision: Restricted Differential Revision.Jul 28 2021, 5:58 PM
sidkmenon added a child revision: Restricted Differential Revision.Jul 28 2021, 6:01 PM
python_modules/dagster/dagster/core/definitions/events.py
123–124

Can you say more about why this is needed?

python_modules/dagster/dagster/core/host_representation/selector.py
50

It seems odd to me that we would want to store the selector, and not the resolved represented object. Otherwise, we'll need to resolve on read instead of on write.

I guess this has to do with the fact that we're trying to handle this in middleware and it's too low-level?

as per convo on the internal diff I think we're going to end up wanting to use ExternalXXXOrigins for this

dgibson requested changes to this revision.Jul 30 2021, 1:24 PM
This revision now requires changes to proceed.Jul 30 2021, 1:24 PM
sidkmenon added a child revision: Restricted Differential Revision.Jul 30 2021, 6:29 PM
sidkmenon added a child revision: Restricted Differential Revision.