Page MenuHomeElementl

dagstermill - yield_result output path account for aliased solids and composite solids
ClosedPublic

Authored by yuhan on Jul 27 2021, 11:49 PM.

Details

Summary

follow up on D9053

use solid.name instead of solid_handle to capture aliases.

Test Plan

unit test

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 28 2021, 12:34 AM
Harbormaster failed remote builds in B34352: Diff 42457!

solid.name doesn't work for composite solids, use solid_handle

yuhan retitled this revision from dagstermill - yield_result output path account for aliased solids to dagstermill - yield_result output path account for aliased solids and composite solids.Jul 28 2021, 3:54 AM
yuhan edited the summary of this revision. (Show Details)
yuhan requested review of this revision.Jul 28 2021, 4:37 AM

agh - should have caught this in review

This revision is now accepted and ready to land.Jul 28 2021, 5:58 PM