Page MenuHomeElementl
Differential D9110

dagstermill - yield_result output path account for aliased solids and composite solids
ClosedPublic
Actions

Authored by • yuhan on Jul 27 2021, 11:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 12, 3:04 AM
Unknown Object (File)
Sat, Mar 11, 12:40 AM
Unknown Object (File)
Sat, Mar 11, 12:40 AM
Unknown Object (File)
Sat, Mar 11, 12:40 AM
Unknown Object (File)
Sat, Mar 11, 12:36 AM
Unknown Object (File)
Thu, Mar 9, 2:59 PM
Unknown Object (File)
Feb 9 2023, 4:26 PM
Unknown Object (File)
Feb 9 2023, 6:41 AM
View All 88 Files
Subscribers
None

Details

Reviewers
alangenfeld
• max
Commits
R1:f1c0a4f53e57: dagstermill - yield_result output path account for aliased solids and composite…
Summary

follow up on D9053

use solid.name instead of solid_handle to capture aliases.

Test Plan

unit test

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• yuhan created this revision.Jul 27 2021, 11:49 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 28 2021, 12:34 AM
Harbormaster failed remote builds in B34352: Diff 42457!
• yuhan updated this revision to Diff 42473.Jul 28 2021, 3:53 AM

solid.name doesn't work for composite solids, use solid_handle

• yuhan retitled this revision from dagstermill - yield_result output path account for aliased solids to dagstermill - yield_result output path account for aliased solids and composite solids.Jul 28 2021, 3:54 AM
• yuhan edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B34368: Diff 42473.Jul 28 2021, 4:37 AM
• yuhan requested review of this revision.Jul 28 2021, 4:37 AM
alangenfeld accepted this revision.Jul 28 2021, 5:58 PM

agh - should have caught this in review

This revision is now accepted and ready to land.Jul 28 2021, 5:58 PM
Closed by commit R1:f1c0a4f53e57: dagstermill - yield_result output path account for aliased solids and composite… (authored by • yuhan). · Explain WhyJul 28 2021, 11:23 PM
This revision was automatically updated to reflect the committed changes.
• yuhan added a commit: R1:f1c0a4f53e57: dagstermill - yield_result output path account for aliased solids and composite….

Revision Contents
Changeset List

PathSize
python_modules/
libraries/
dagstermill/
dagstermill/
6 lines
examples/
62 lines
10 lines
dagstermill_tests/
24 lines

Diff 42549

View Options

python_modules/libraries/dagstermill/dagstermill/context.py

Loading...
View Options

python_modules/libraries/dagstermill/dagstermill/examples/repository.py

Loading...
View Options

python_modules/libraries/dagstermill/dagstermill/manager.py

Loading...
View Options

python_modules/libraries/dagstermill/dagstermill_tests/test_solids.py

Loading...