Page MenuHomeElementl

[dagit] Fix Gantt chart time indicators offset from step edges when scrollbars present #4408
ClosedPublic

Authored by bengotow on Jul 27 2021, 9:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 11, 8:40 PM
Unknown Object (File)
Sun, Sep 11, 6:33 PM
Unknown Object (File)
Fri, Sep 9, 8:05 AM
Unknown Object (File)
Aug 19 2022, 11:46 AM
Unknown Object (File)
Aug 12 2022, 3:42 PM
Unknown Object (File)
Aug 12 2022, 3:42 PM
Unknown Object (File)
Aug 11 2022, 4:19 PM
Unknown Object (File)
Jul 27 2022, 10:46 PM
Subscribers
None

Details

Summary

The ticks sit on top of the Gantt scroll view and not inside it, so they need to be positioned accurately based on the size of the scroll view beneath them. The viewport measurement helper was using getBoundingCLientRect() which includes the scrollbars in the width + height of the element and we needed to use clientWidth / clientHeight instead.

Test Plan

Observe problem is fixed with mouse plugged in

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable