Differential D9102

[dagit] Fix Gantt chart time indicators offset from step edges when scrollbars present #4408
ClosedPublic
Actions

Authored by • bengotow on Jul 27 2021, 9:42 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Feb 5, 3:43 AM

	Unknown Object (File)
	Thu, Feb 2, 3:14 PM

	Unknown Object (File)
	Wed, Feb 1, 11:14 PM

	Unknown Object (File)
	Tue, Jan 31, 12:16 AM

	Unknown Object (File)
	Dec 26 2022, 8:26 PM

	Unknown Object (File)
	Dec 25 2022, 5:45 PM

	Unknown Object (File)
	Dec 13 2022, 10:29 PM

	Unknown Object (File)
	Nov 19 2022, 5:30 PM

View All 56 Files

Subscribers

None

Details

Reviewers

Commits

R1:87a3e5a0f373: [dagit] Fix Gantt chart time indicators offset from step edges when scrollbars…

Summary

The ticks sit on top of the Gantt scroll view and not inside it, so they need to be positioned accurately based on the size of the scroll view beneath them. The viewport measurement helper was using getBoundingCLientRect() which includes the scrollbars in the width + height of the element and we needed to use clientWidth / clientHeight instead.

Test Plan

Observe problem is fixed with mouse plugged in

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• bengotow created this revision.Jul 27 2021, 9:42 PM

Harbormaster completed remote builds in B34337: Diff 42441.Jul 27 2021, 9:51 PM

• bengotow requested review of this revision.Jul 27 2021, 9:51 PM

• dish accepted this revision.Jul 28 2021, 2:23 PM

This revision is now accepted and ready to land.Jul 28 2021, 2:23 PM

Closed by commit R1:87a3e5a0f373: [dagit] Fix Gantt chart time indicators offset from step edges when scrollbars… (authored by • bengotow). · Explain WhyJul 29 2021, 3:04 PM

This revision was automatically updated to reflect the committed changes.

• bengotow added a commit: R1:87a3e5a0f373: [dagit] Fix Gantt chart time indicators offset from step edges when scrollbars….

Revision Contents
Changeset List

Path

Size

js_modules/

dagit/

packages/

core/

src/

gantt/

useViewport.tsx

7 lines

Diff 42581

js_modules/dagit/packages/core/src/gantt/useViewport.tsx

Loading...