Differential D9100

[dagit] Pad the bottom of the Gantt chart to avoid last row of steps behind search box #4389
ClosedPublic
Actions

Authored by • bengotow on Jul 27 2021, 9:22 PM.

Details

Reviewers

• dish

Commits

R1:86210d56704b: [dagit] Pad the bottom of the Gantt chart to avoid last row of steps behind…

Summary

Just some missing padding on the container

Test Plan

Verified that it looks good, scrolls correctly, padding does not cause N = N + 100 forever issue with viewport sizing

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• bengotow created this revision.Jul 27 2021, 9:22 PM

Update

Harbormaster completed remote builds in B34334: Diff 42438.Jul 27 2021, 9:32 PM

Harbormaster completed remote builds in B34335: Diff 42439.Jul 27 2021, 9:38 PM

• bengotow requested review of this revision.Jul 27 2021, 9:38 PM

• dish accepted this revision.Jul 28 2021, 2:23 PM

This revision is now accepted and ready to land.Jul 28 2021, 2:23 PM

Closed by commit R1:86210d56704b: [dagit] Pad the bottom of the Gantt chart to avoid last row of steps behind… (authored by • bengotow). · Explain WhyJul 29 2021, 3:03 PM

This revision was automatically updated to reflect the committed changes.

• bengotow added a commit: R1:86210d56704b: [dagit] Pad the bottom of the Gantt chart to avoid last row of steps behind….

Revision Contents
Changeset List

Path

Size

js_modules/

dagit/

packages/

core/

src/

gantt/

GanttChart.tsx

2 lines

GanttChartTimescale.tsx

2 lines

Diff 42580

View Options

js_modules/dagit/packages/core/src/gantt/GanttChart.tsx