Page MenuHomeElementl
Differential D9081

Use grpc rather than ipc to decide if a grpc server is running" - with integration test fix
ClosedPublic
Actions

Authored by • dgibson on Jul 27 2021, 3:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 11, 12:24 AM
Unknown Object (File)
Apr 22 2023, 6:32 PM
Unknown Object (File)
Apr 22 2023, 12:23 PM
Unknown Object (File)
Apr 9 2023, 12:28 PM
Unknown Object (File)
Mar 17 2023, 6:50 PM
Unknown Object (File)
Mar 11 2023, 1:03 AM
Unknown Object (File)
Mar 11 2023, 1:03 AM
Unknown Object (File)
Mar 11 2023, 1:03 AM
View All 83 Files
Subscribers
None

Details

Reviewers
None
Commits
R1:29797eb9c6c9: Use grpc rather than ipc to decide if a grpc server is running" - with…
Summary

This reverts commit 5b6e23b470c5d15d26955d7bfbb5fc9aff384528, with one change - detect any load errors on startup before any multi-threading might happen, then cache them for any subsequent ListRepostiories calls.

Test Plan

Integration

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
grpc/
1 line
174 lines
dagster_tests/
core_tests/
host_representation_tests/
29 lines
general_tests/
grpc_tests/
323 lines

Diff 42371

View Options

python_modules/dagster/dagster/grpc/client.py

Loading...
View Options

python_modules/dagster/dagster/grpc/server.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/host_representation_tests/test_grpc_server_registry.py

Loading...
View Options

python_modules/dagster/dagster_tests/general_tests/grpc_tests/test_persistent.py

Loading...