Page MenuHomeElementl
Differential D9080

fix(helm): use correct templating logic for compute log manager
ClosedPublic
Actions

Authored by • rexledesma on Jul 27 2021, 3:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 5, 2:21 AM
Unknown Object (File)
Tue, Jan 31, 11:35 PM
Unknown Object (File)
Tue, Jan 24, 6:02 AM
Unknown Object (File)
Sat, Jan 7, 11:50 PM
Unknown Object (File)
Jan 5 2023, 3:26 AM
Unknown Object (File)
Dec 13 2022, 10:25 PM
Unknown Object (File)
Nov 19 2022, 3:49 PM
Unknown Object (File)
Nov 14 2022, 9:23 PM
View All 62 Files
Subscribers
None

Details

Reviewers
• johann
alangenfeld
Commits
R1:e589f1010807: fix(helm): use correct templating logic for compute log manager
Summary

Use correct if/else if constructs. While adding tests, it seems like
we didn't template skipEmptyFiles in the s3 compute log manager.
Correct that as well.

Test Plan

pytest

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
helm/
dagster/
schema/
schema_tests/
147 lines
templates/
3 lines
helpers/
instance/
4 lines

Diff 42369

View Options

helm/dagster/schema/schema_tests/test_instance.py

Loading...
View Options

helm/dagster/templates/configmap-instance.yaml

Loading...
View Options

helm/dagster/templates/helpers/instance/_compute-log-manager.tpl

Loading...