Page MenuHomeElementl
Differential D9080

fix(helm): use correct templating logic for compute log manager
ClosedPublic
Actions

Authored by • rexledesma on Jul 27 2021, 3:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 12, 3:30 PM
Unknown Object (File)
Fri, Aug 12, 3:29 PM
Unknown Object (File)
Thu, Aug 11, 6:56 AM
Unknown Object (File)
Sun, Aug 7, 3:33 AM
Unknown Object (File)
Wed, Jul 27, 10:35 PM
Unknown Object (File)
Sun, Jul 24, 10:49 AM
Unknown Object (File)
Sat, Jul 23, 7:00 PM
Unknown Object (File)
Sat, Jul 23, 8:31 AM
View All 29 Files
Subscribers
None

Details

Reviewers
• johann
alangenfeld
Commits
R1:e589f1010807: fix(helm): use correct templating logic for compute log manager
Summary

Use correct if/else if constructs. While adding tests, it seems like
we didn't template skipEmptyFiles in the s3 compute log manager.
Correct that as well.

Test Plan

pytest

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
helm/
dagster/
schema/
schema_tests/
147 lines
templates/
3 lines
helpers/
instance/
4 lines

Diff 42369

View Options

helm/dagster/schema/schema_tests/test_instance.py

Loading...
View Options

helm/dagster/templates/configmap-instance.yaml

Loading...
View Options

helm/dagster/templates/helpers/instance/_compute-log-manager.tpl

Loading...