Differential D9079

Revert "Use grpc rather than ipc to decide if a grpc server is running"
ClosedPublic
Actions

Authored by • dgibson on Jul 27 2021, 3:13 PM.

Details

Reviewers: None
Commits: R1:5b6e23b470c5: Revert "Use grpc rather than ipc to decide if a grpc server is running"

Summary

This reverts commit 1a5433f9d9dc33c234cd5ed267878ffe0568f37b due to scary daemon integration test failures.

Test Plan

Revert

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• dgibson created this revision.Jul 27 2021, 3:13 PM

This revision was not accepted when it landed; it landed in state Draft.Jul 27 2021, 3:14 PM

This revision was landed with ongoing or failed builds.

Closed by commit R1:5b6e23b470c5: Revert "Use grpc rather than ipc to decide if a grpc server is running" (authored by • dgibson). · Explain Why

This revision was automatically updated to reflect the committed changes.

• dgibson added a commit: R1:5b6e23b470c5: Revert "Use grpc rather than ipc to decide if a grpc server is running".

• dgibson added a reverting change: D9081: Use grpc rather than ipc to decide if a grpc server is running" - with integration test fix.Jul 27 2021, 3:52 PM

Harbormaster completed remote builds in B34268: Diff 42357.Jul 27 2021, 3:57 PM

• dgibson added a reverting change: R1:29797eb9c6c9: Use grpc rather than ipc to decide if a grpc server is running" - with….Jul 27 2021, 4:27 PM

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

grpc/

client.py

1 line

server.py

165 lines

dagster_tests/

core_tests/

host_representation_tests/

test_grpc_server_registry.py

29 lines

general_tests/

grpc_tests/

test_persistent.py

323 lines

Diff 42358

View Options

python_modules/dagster/dagster/grpc/client.py

View Options

python_modules/dagster/dagster/grpc/server.py

View Options

python_modules/dagster/dagster_tests/core_tests/host_representation_tests/test_grpc_server_registry.py

View Options

python_modules/dagster/dagster_tests/general_tests/grpc_tests/test_persistent.py

Revert "Use grpc rather than ipc to decide if a grpc server is running"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42358

python_modules/dagster/dagster/grpc/client.py

python_modules/dagster/dagster/grpc/server.py

python_modules/dagster/dagster_tests/core_tests/host_representation_tests/test_grpc_server_registry.py

python_modules/dagster/dagster_tests/general_tests/grpc_tests/test_persistent.py

Revert "Use grpc rather than ipc to decide if a grpc server is running"
ClosedPublic
Actions

Revision Contents
Changeset List