Page MenuHomeElementl

delegate k8s executor config to run launcher if it isn't set, instead of assuming default
ClosedPublic

Authored by dgibson on Jul 27 2021, 2:30 PM.

Details

Summary

This may slightly change behavior for early users using the k8s executor? The idea is to not need to specify the same exact config on teh run launcher and the executor.

Test Plan

Integration

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jul 27 2021, 3:17 PM

add the rest of fields, which surfaces a bit of image pull policy inconsistency with the celery k8s config / run launcher..

dgibson retitled this revision from RFC: delegate job namespace to run launcher if it isn't set, instead of assuming default to RFC: delegate k8s executor config to run launcher if it isn't set, instead of assuming default.
dgibson edited the summary of this revision. (Show Details)
dgibson edited the test plan for this revision. (Show Details)

up

back to queue since this is a much more comprehensive change now

This revision is now accepted and ready to land.Jul 27 2021, 7:58 PM
dgibson retitled this revision from RFC: delegate k8s executor config to run launcher if it isn't set, instead of assuming default to delegate k8s executor config to run launcher if it isn't set, instead of assuming default.Jul 28 2021, 4:22 PM
This revision is now accepted and ready to land.Jul 28 2021, 5:33 PM