Page MenuHomeElementl

[dagit] Modify App initialization config
ClosedPublic

Authored by dish on Jul 26 2021, 9:21 PM.

Details

Summary

A couple things:

  • The subscriptionParams config value is not currently used
  • We want to have the flexibility to add headers to HttpLink

These headers will also be applied as the connectionParams. This is a little awkward, but seems like it might be the best way for us to get initialization info to the server.

Test Plan

Buildkite. Run Dagit, verify that all http and ws connections behave correctly.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish requested review of this revision.Jul 26 2021, 9:30 PM
dish edited the test plan for this revision. (Show Details)
dish added reviewers: bengotow, prha.
This revision is now accepted and ready to land.Jul 27 2021, 3:20 PM
This revision was automatically updated to reflect the committed changes.