Page MenuHomeElementl

[dagit] Modify App initialization config
ClosedPublic

Authored by dish on Jul 26 2021, 9:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 12, 3:24 PM
Unknown Object (File)
Fri, Aug 12, 3:24 PM
Unknown Object (File)
Thu, Aug 11, 11:54 PM
Unknown Object (File)
Mon, Aug 1, 8:24 PM
Unknown Object (File)
Wed, Jul 27, 10:28 PM
Unknown Object (File)
Mon, Jul 25, 8:57 PM
Unknown Object (File)
Sun, Jul 24, 9:17 AM
Unknown Object (File)
Sat, Jul 23, 1:15 PM
Subscribers
None

Details

Summary

A couple things:

  • The subscriptionParams config value is not currently used
  • We want to have the flexibility to add headers to HttpLink

These headers will also be applied as the connectionParams. This is a little awkward, but seems like it might be the best way for us to get initialization info to the server.

Test Plan

Buildkite. Run Dagit, verify that all http and ws connections behave correctly.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish edited the test plan for this revision. (Show Details)
dish added reviewers: bengotow, prha.
This revision is now accepted and ready to land.Jul 27 2021, 3:20 PM
This revision was automatically updated to reflect the committed changes.