Page MenuHomeElementl

[dagit] Modify App initialization config

Authored by dish on Jul 26 2021, 9:21 PM.
Referenced Files
F2902437: D9065.diff
Sat, Apr 1, 11:02 AM
F2901962: D9065.diff
Sat, Apr 1, 4:08 AM
Unknown Object (File)
Tue, Mar 28, 1:14 AM
Unknown Object (File)
Thu, Mar 16, 11:36 AM
Unknown Object (File)
Tue, Mar 14, 3:47 AM
Unknown Object (File)
Sat, Mar 11, 4:08 AM
Unknown Object (File)
Sat, Mar 11, 4:04 AM
Unknown Object (File)
Sat, Mar 11, 4:04 AM



A couple things:

  • The subscriptionParams config value is not currently used
  • We want to have the flexibility to add headers to HttpLink

These headers will also be applied as the connectionParams. This is a little awkward, but seems like it might be the best way for us to get initialization info to the server.

Test Plan

Buildkite. Run Dagit, verify that all http and ws connections behave correctly.

Diff Detail

R1 dagster
Lint Not Applicable
Tests Not Applicable

Event Timeline

dish edited the test plan for this revision. (Show Details)
dish added reviewers: bengotow, prha.
This revision is now accepted and ready to land.Jul 27 2021, 3:20 PM
This revision was automatically updated to reflect the committed changes.