Page MenuHomeElementl
Differential D9065

[dagit] Modify App initialization config
ClosedPublic
Actions

Authored by • dish on Jul 26 2021, 9:21 PM.
Tags
None
Referenced Files
F2902437: D9065.diff
Sat, Apr 1, 11:02 AM
F2901962: D9065.diff
Sat, Apr 1, 4:08 AM
Unknown Object (File)
Tue, Mar 28, 1:14 AM
Unknown Object (File)
Thu, Mar 16, 11:36 AM
Unknown Object (File)
Tue, Mar 14, 3:47 AM
Unknown Object (File)
Sat, Mar 11, 4:08 AM
Unknown Object (File)
Sat, Mar 11, 4:04 AM
Unknown Object (File)
Sat, Mar 11, 4:04 AM
View All Files
Subscribers
None

Details

Reviewers
• dgibson
• bengotow
• prha
Commits
R1:7a03bb0ffe30: [dagit] Modify App initialization config
Summary

A couple things:

  • The subscriptionParams config value is not currently used
  • We want to have the flexibility to add headers to HttpLink

These headers will also be applied as the connectionParams. This is a little awkward, but seems like it might be the best way for us to get initialization info to the server.

Test Plan

Buildkite. Run Dagit, verify that all http and ws connections behave correctly.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• dish created this revision.Jul 26 2021, 9:21 PM
Harbormaster completed remote builds in B34219: Diff 42297.Jul 26 2021, 9:30 PM
• dish requested review of this revision.Jul 26 2021, 9:30 PM
• dish edited the summary of this revision. (Show Details)Jul 27 2021, 2:19 PM
• dish edited the test plan for this revision. (Show Details)
• dish added reviewers: • bengotow, • prha.
• prha accepted this revision.Jul 27 2021, 3:20 PM
This revision is now accepted and ready to land.Jul 27 2021, 3:20 PM
Closed by commit R1:7a03bb0ffe30: [dagit] Modify App initialization config (authored by • dish). · Explain WhyJul 27 2021, 3:30 PM
This revision was automatically updated to reflect the committed changes.
• dish added a commit: R1:7a03bb0ffe30: [dagit] Modify App initialization config.

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
packages/
core/
src/
app/
12 lines

Diff 42360

View Options

js_modules/dagit/packages/core/src/app/AppProvider.tsx

Loading...