Page MenuHomeElementl

feat(helm): set compute log manager default as noop
ClosedPublic

Authored by rexledesma on Jul 23 2021, 2:19 PM.

Details

Summary

In a Helm deployment of Dagster, it does not make sense to default to the
local compute log manager as pipeline runs are executed in ephemeral jobs.
In a Kubernetes environment, users should default to using a cloud provider
to host their compute logs.

We should deprecate the local compute log manager as configuration in our Helm
chart. Now, we default to the noop compute log manager. To prevent this from being
a breaking change, if the user previous specified the local compute log manager,
it will now noop (since it wasn't doing anything in the first place).

Test Plan

pytest

Diff Detail

Repository
R1 dagster
Branch
rl/local-compute-to-no-op (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

ya this is the right call

helm/dagster/schema/schema/charts/dagster/subschema/compute_log_manager.py
11–12

nit: comment here about deprecated

helm/dagster/values.yaml
135

nit maybe call more detail here - that it actually just points to NoOp

This revision is now accepted and ready to land.Jul 23 2021, 4:22 PM