Page MenuHomeElementl

[dagit] Fix manifest
ClosedPublic

Authored by dish on Jul 22 2021, 8:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 12, 12:08 AM
Unknown Object (File)
Sun, Sep 4, 1:10 AM
Unknown Object (File)
Aug 25 2022, 7:45 AM
Unknown Object (File)
Aug 18 2022, 1:12 PM
Unknown Object (File)
Aug 15 2022, 10:33 PM
Unknown Object (File)
Aug 10 2022, 11:55 PM
Unknown Object (File)
Aug 7 2022, 1:48 PM
Unknown Object (File)
Aug 5 2022, 10:50 AM
Subscribers
None

Details

Summary

The manifest currently fails to load in cases where auth is required on the backend, as credentials are not included in the request. Fix this, as indicated by https://developer.mozilla.org/en-US/docs/Web/Manifest#deploying_a_manifest_with_the_link_tag.

Test Plan

Load Dagit in prod build and dev build. Verify that the manifest request succeeds with no errors.

Diff Detail

Repository
R1 dagster
Branch
dish-manifest
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Oh wow haven't seen this before, good find

This revision is now accepted and ready to land.Jul 27 2021, 6:31 PM
This revision was automatically updated to reflect the committed changes.