Page MenuHomeElementl

[dagit] Fix manifest
ClosedPublic

Authored by dish on Jul 22 2021, 8:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 15, 10:33 PM
Unknown Object (File)
Wed, Aug 10, 11:55 PM
Unknown Object (File)
Sun, Aug 7, 1:48 PM
Unknown Object (File)
Fri, Aug 5, 10:50 AM
Unknown Object (File)
Sun, Jul 31, 4:43 AM
Unknown Object (File)
Sat, Jul 23, 8:23 AM
Unknown Object (File)
Wed, Jul 20, 12:28 AM
Unknown Object (File)
Mon, Jul 18, 7:37 PM
Subscribers
None

Details

Summary

The manifest currently fails to load in cases where auth is required on the backend, as credentials are not included in the request. Fix this, as indicated by https://developer.mozilla.org/en-US/docs/Web/Manifest#deploying_a_manifest_with_the_link_tag.

Test Plan

Load Dagit in prod build and dev build. Verify that the manifest request succeeds with no errors.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Oh wow haven't seen this before, good find

This revision is now accepted and ready to land.Jul 27 2021, 6:31 PM
This revision was automatically updated to reflect the committed changes.