changes for 0.12.3
ClosedPublic
Actions

Authored by • sandyryza on Jul 22 2021, 6:54 PM.

Details

Reviewers

alangenfeld
• jordansanders

Commits

R1:af93a816e25a: changes for 0.12.3

Test Plan

none

Diff Detail

Repository

R1 dagster

Branch

changelog (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• sandyryza created this revision.Jul 22 2021, 6:54 PM

• sandyryza published this revision for review.Jul 22 2021, 7:05 PM

• yuhan added a subscriber: • yuhan.Jul 22 2021, 7:11 PM

• yuhan added inline comments.

CHANGES.md
7	we use `-` instead of `*` in changelog
31	this bullet point doesn't make sense

Let's definitely remove the "Added information" line 😄

CHANGES.md
7	s/*/- for consistency We should install a linter to enforce this going forward 😄
13
15
23	nit - we're pretty inconsistent about when we backtick and when we string quote things like keys, properties, etc. For example, the `description` property on line 14 is backticked :shrug:
31	Uh... Let's remove this haha.
32	Also not sure if this really warrants a changelog entry but :shrug:

This revision now requires changes to proceed.Jul 22 2021, 7:12 PM

@jordansanders how strongly do you feel about stars vs. dashes? I don't mind changing this time, but fairly annoying if that needs to be another step in the release guide. (the stars are generated by the Quip markdown export).

Harbormaster completed remote builds in B34086: Diff 42116.Jul 22 2021, 7:20 PM

In D9021#234129, @sandyryza wrote:

@jordansanders how strongly do you feel about stars vs. dashes? I don't mind changing this time, but fairly annoying if that needs to be another step in the release guide. (the stars are generated by the Quip markdown export).

I feel very not strongly and think we should add a linter if we actually care 😃 . I'm looking into this now.

I think others feel slightly more strongly because I've been asked to change it every week when I release.