Page MenuHomeElementl

changes for 0.12.3
ClosedPublic

Authored by sandyryza on Jul 22 2021, 6:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 18, 1:35 AM
Unknown Object (File)
Fri, Nov 18, 1:35 AM
Unknown Object (File)
Fri, Nov 18, 1:35 AM
Unknown Object (File)
Fri, Nov 18, 1:35 AM
Unknown Object (File)
Mon, Nov 14, 8:28 PM
Unknown Object (File)
Wed, Nov 9, 11:49 AM
Unknown Object (File)
Sat, Nov 5, 4:38 AM
Unknown Object (File)
Fri, Nov 4, 9:15 AM

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

yuhan added inline comments.
CHANGES.md
7

we use - instead of * in changelog

31

this bullet point doesn't make sense

Let's definitely remove the "Added information" line 😄

CHANGES.md
7

s/*/- for consistency

We should install a linter to enforce this going forward 😄

13
15
23

nit - we're pretty inconsistent about when we backtick and when we string quote things like keys, properties, etc. For example, the description property on line 14 is backticked :shrug:

31

Uh...

Let's remove this haha.

32

Also not sure if this really warrants a changelog entry but :shrug:

This revision now requires changes to proceed.Jul 22 2021, 7:12 PM

@jordansanders how strongly do you feel about stars vs. dashes? I don't mind changing this time, but fairly annoying if that needs to be another step in the release guide. (the stars are generated by the Quip markdown export).

@jordansanders how strongly do you feel about stars vs. dashes? I don't mind changing this time, but fairly annoying if that needs to be another step in the release guide. (the stars are generated by the Quip markdown export).

I feel very not strongly and think we should add a linter if we actually care 😃 . I'm looking into this now.

I think others feel slightly more strongly because I've been asked to change it every week when I release.

This revision is now accepted and ready to land.Jul 22 2021, 7:24 PM
This revision was automatically updated to reflect the committed changes.