Add an error boundary around check_add_heartbeat in daemon loop
ClosedPublic
Actions

Authored by • dgibson on Jul 22 2021, 6:41 PM.

Details

Reviewers

• johann
• rexledesma
alangenfeld

Commits

R1:fab04af76aab: Add an error boundary around check_add_heartbeat in daemon loop

Summary

There are two heartbeat additions here in this file - we wrapped one of them in a guard but not the other one. This diff adds it to the other one.

Test Plan

BK, run a daemon that fails this check (e.g. with bad run storage credentials), daemon logs instead of crashing. Heartbeat failures may eventually cause it to crash, but not right away.

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• dgibson created this revision.Jul 22 2021, 6:41 PM

Harbormaster completed remote builds in B34085: Diff 42115.Jul 22 2021, 7:14 PM

• dgibson requested review of this revision.Jul 22 2021, 7:14 PM

• rexledesma accepted this revision.Jul 22 2021, 7:19 PM

This revision is now accepted and ready to land.Jul 22 2021, 7:19 PM

Closed by commit R1:fab04af76aab: Add an error boundary around check_add_heartbeat in daemon loop (authored by • dgibson). · Explain WhyJul 22 2021, 7:23 PM

This revision was automatically updated to reflect the committed changes.

• dgibson added a commit: R1:fab04af76aab: Add an error boundary around check_add_heartbeat in daemon loop.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

daemon/

daemon.py

16 lines

Diff 42136

View Options

python_modules/dagster/dagster/daemon/daemon.py

Add an error boundary around check_add_heartbeat in daemon loopClosedPublicActions