Page MenuHomeElementl

Add an error boundary around check_add_heartbeat in daemon loop
ClosedPublic

Authored by dgibson on Jul 22 2021, 6:41 PM.

Details

Summary

There are two heartbeat additions here in this file - we wrapped one of them in a guard but not the other one. This diff adds it to the other one.

Test Plan

BK, run a daemon that fails this check (e.g. with bad run storage credentials), daemon logs instead of crashing. Heartbeat failures may eventually cause it to crash, but not right away.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable