Page MenuHomeElementl

[dagit] Handle WS issue in CSP for Safari
ClosedPublic

Authored by dish on Jul 22 2021, 5:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Aug 12, 2:37 PM
Unknown Object (File)
Fri, Aug 5, 6:50 PM
Unknown Object (File)
Mon, Aug 1, 2:18 PM
Unknown Object (File)
Sat, Jul 23, 8:33 AM
Unknown Object (File)
Jul 15 2022, 3:39 AM
Unknown Object (File)
Jul 15 2022, 3:39 AM
Unknown Object (File)
Jul 15 2022, 3:39 AM
Unknown Object (File)
Jul 15 2022, 3:39 AM
Subscribers
None

Details

Summary

The connect-src: 'self' configuration in the CSP is failing in Safari, which is rejecting WebSocket connections. Add ws: and wss:, which is really unfortunate. I'd like to fix Safari temporarily with this, but would really prefer a better long-term solution than this.

Test Plan

Test dev and prod builds in Chrome, Firefox, Safari. Verify that Dagit loads and performs WS connections correctly.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jul 22 2021, 6:03 PM
This revision was landed with ongoing or failed builds.Jul 22 2021, 6:03 PM
This revision was automatically updated to reflect the committed changes.