loading
ClosedPublic
Actions

Authored by dgibson on Jul 21 2021, 3:32 PM.

Details

Reviewers

Commits

R1:287be3de595c: Don't show an error/failure result when a repo location transitions from error…

Summary

When you reload a repo location while it's in an error state, its status changes to LOADING, but the previous error is still on the locationOrLoadError field. We should treat that state as loading, not as error.

Test Plan

Transition from an error state to a success state, no immediate error while it's reloading.

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dgibson created this revision.Jul 21 2021, 3:32 PM

Harbormaster completed remote builds in B33976: Diff 41967.Jul 21 2021, 3:43 PM

dgibson requested review of this revision.Jul 21 2021, 3:43 PM

dish accepted this revision.Jul 21 2021, 4:47 PM

This revision is now accepted and ready to land.Jul 21 2021, 4:47 PM

Closed by commit R1:287be3de595c: Don't show an error/failure result when a repo location transitions from error… (authored by dgibson). · Explain WhyJul 21 2021, 5:23 PM

This revision was automatically updated to reflect the committed changes.

dgibson added a commit: R1:287be3de595c: Don't show an error/failure result when a repo location transitions from error….

Revision Contents
Changeset List

Path

Size

js_modules/

dagit/

packages/

core/

src/

nav/

ReloadRepositoryLocationButton.tsx

8 lines

Diff 41980

View Options

js_modules/dagit/packages/core/src/nav/ReloadRepositoryLocationButton.tsx

Don't show an error/failure result when a repo location transitions from error => loadingClosedPublicActions