Page MenuHomeElementl
Differential D8956

[dagit] Show start/end information on latest run in Job details
ClosedPublic
Actions

Authored by • dish on Jul 19 2021, 9:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Aug 6, 1:58 PM
Unknown Object (File)
Thu, Aug 4, 5:40 AM
Unknown Object (File)
Sun, Jul 31, 11:48 AM
Unknown Object (File)
Sun, Jul 24, 9:08 AM
Unknown Object (File)
Sun, Jul 24, 4:42 AM
Unknown Object (File)
Sun, Jul 24, 2:22 AM
Unknown Object (File)
Sat, Jul 23, 1:06 AM
Unknown Object (File)
Fri, Jul 22, 12:36 PM
View All 46 Files
Subscribers
None

Details

Reviewers
• bengotow
• sandyryza
Commits
R1:62568ae3388e: [dagit] Show start/end information on latest run in Job details
Summary

On the job details header metadata, add a tooltip to the duration text to indicate the started/ended values of the run.

I don't really have enough space here to add these directly to the header instead of the duration, but hopefully this is useful.

Test Plan

View a job with a run, verify that the tooltip shows the correct information.

Diff Detail

Repository
R1 dagster
Branch
dish-run-time
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

• dish created this revision.Jul 19 2021, 9:14 PM
• dish added a comment.Jul 19 2021, 9:14 PM

Screen Shot 2021-07-19 at 4.04.32 PM.png (230×534 px, 46 KB)

• dish updated this revision to Diff 41828.Jul 19 2021, 9:16 PM

Rebase

Harbormaster completed remote builds in B33867: Diff 41826.Jul 19 2021, 9:26 PM
Harbormaster completed remote builds in B33868: Diff 41828.Jul 19 2021, 9:29 PM
• dish requested review of this revision.Jul 19 2021, 9:29 PM
• sandyryza added a comment.Jul 19 2021, 9:34 PM

Thoughts on replacing the duration with the most recent start time in the header? I think the most recent start time is a more useful piece of information than the duration.

• dish updated this revision to Diff 41907.Jul 20 2021, 6:41 PM

Use RunTime instead

• dish updated this revision to Diff 41908.Jul 20 2021, 6:42 PM

Remove TimeElapsed change

Harbormaster completed remote builds in B33928: Diff 41907.Jul 20 2021, 6:52 PM
Harbormaster completed remote builds in B33929: Diff 41908.Jul 20 2021, 6:55 PM
• dish updated this revision to Diff 42252.Jul 26 2021, 3:06 PM

Rebase

Harbormaster completed remote builds in B34183: Diff 42252.Jul 26 2021, 3:16 PM
• sandyryza accepted this revision.Jul 26 2021, 3:51 PM
This revision is now accepted and ready to land.Jul 26 2021, 3:51 PM
• dish updated this revision to Diff 42359.Jul 27 2021, 3:29 PM

Rebase

Harbormaster completed remote builds in B34269: Diff 42359.Jul 27 2021, 3:40 PM
Closed by commit R1:62568ae3388e: [dagit] Show start/end information on latest run in Job details (authored by • dish). · Explain WhyJul 27 2021, 3:49 PM
This revision was automatically updated to reflect the committed changes.
• dish added a commit: R1:62568ae3388e: [dagit] Show start/end information on latest run in Job details.

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
packages/
core/
src/
nav/
85 lines
types/
runs/
2 lines
3 lines
ui/
2 lines

Diff 42252

View Options

js_modules/dagit/packages/core/src/nav/JobMetadata.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/nav/types/JobMetadataQuery.ts

Loading...
View Options

js_modules/dagit/packages/core/src/nav/types/RunMetadataFragment.ts

Loading...
View Options

js_modules/dagit/packages/core/src/runs/RunDetails.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/runs/RunUtils.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/ui/MetadataTable.tsx

Loading...