Details
Diff Detail
- Repository
- R1 dagster
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| python_modules/dagster/setup.py | ||
|---|---|---|
| 86 | we do is_module_available("docstring_parser") where this is used too if we want to do the more aggressive version of not requiring it at all | |
can we make sure the make build in docs still works - iirc we had some lib version related issue when building the api docs. i could be wrong but just wanted to make sure unpinning it wont break the docs build.
can we make sure the make build in docs still works - iirc we had some lib version related issue when building the api docs. i could be wrong but just wanted to make sure unpinning it wont break the docs build.
does the BK run not hit that? I ran it locally after forcing an upgrade on docstring-parser and it still works
if it's version conflict, the make build cmd won't hard fail so BK won't be able to capture it. instead, if anything errors in the middle, it'd print out the errors and results empty json output for the ones that has conflict.
if api docs rendering is good, then it's good to go.