Page MenuHomeElementl

[crag] fix snapshots handling composed @graph
ClosedPublic

Authored by alangenfeld on Jul 19 2021, 3:34 PM.

Details

Summary

Snapshot code was still coded against CompositeSolidDefinition checks without a fall-through so

  • fix it
  • re-arrange it to have a check.failed for unhandled node types
  • rename getter to node since it has graphs and solids
Test Plan

added tests

Diff Detail

Repository
R1 dagster
Branch
job-bug (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 19 2021, 3:59 PM
Harbormaster failed remote builds in B33846: Diff 41802!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 19 2021, 6:16 PM
Harbormaster failed remote builds in B33851: Diff 41808!
This revision is now accepted and ready to land.Jul 22 2021, 3:33 PM