Page MenuHomeElementl
Differential D8943

[crag] fix snapshots handling composed @graph
ClosedPublic
Actions

Authored by alangenfeld on Jul 19 2021, 3:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 16, 7:13 PM
Unknown Object (File)
Thu, Sep 15, 6:11 PM
Unknown Object (File)
Aug 16 2022, 7:36 PM
Unknown Object (File)
Aug 16 2022, 7:36 PM
Unknown Object (File)
Aug 16 2022, 7:36 PM
Unknown Object (File)
Aug 12 2022, 1:31 PM
Unknown Object (File)
Aug 12 2022, 1:29 PM
Unknown Object (File)
Aug 12 2022, 1:28 PM
View All 30 Files
Subscribers
None

Details

Reviewers
• cdecarolis
• owen
• yuhan
• prha
• sandyryza
Commits
R1:6af4c12ea15e: [crag] fix snapshots handling composed @graph
Summary

Snapshot code was still coded against CompositeSolidDefinition checks without a fall-through so

  • fix it
  • re-arrange it to have a check.failed for unhandled node types
  • rename getter to node since it has graphs and solids
Test Plan

added tests

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alangenfeld created this revision.Jul 19 2021, 3:34 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 19 2021, 3:59 PM
Harbormaster failed remote builds in B33846: Diff 41802!
alangenfeld updated this revision to Diff 41808.Jul 19 2021, 5:12 PM

snaps

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 19 2021, 6:16 PM
Harbormaster failed remote builds in B33851: Diff 41808!
alangenfeld updated this revision to Diff 41835.Jul 19 2021, 10:13 PM

fix test

Harbormaster completed remote builds in B33874: Diff 41835.Jul 19 2021, 10:40 PM
alangenfeld requested review of this revision.Jul 19 2021, 10:40 PM
alangenfeld added reviewers: • prha, • sandyryza.Jul 21 2021, 4:27 PM
alangenfeld updated this revision to Diff 42070.Jul 22 2021, 3:14 PM

rebase

• sandyryza accepted this revision.Jul 22 2021, 3:33 PM
This revision is now accepted and ready to land.Jul 22 2021, 3:33 PM
Harbormaster completed remote builds in B34055: Diff 42070.Jul 22 2021, 4:00 PM
Closed by commit R1:6af4c12ea15e: [crag] fix snapshots handling composed @graph (authored by alangenfeld). · Explain WhyJul 22 2021, 4:45 PM
This revision was automatically updated to reflect the committed changes.
alangenfeld added a commit: R1:6af4c12ea15e: [crag] fix snapshots handling composed @graph.

Revision Contents
Changeset List

PathSize
python_modules/
dagster-graphql/
dagster_graphql/
schema/
24 lines
dagster_graphql_tests/
graphql/
6 lines
snapshots/
9 lines
dagster/
dagster/
cli/
2 lines
core/
host_representation/
8 lines
4 lines
snap/
2 lines
37 lines
dagster_tests/
core_tests/
graph_tests/
55 lines
snap_tests/
20 lines

Diff 42086

View Options

python_modules/dagster-graphql/dagster_graphql/schema/solids.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/setup.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_all_snapshot_ids.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_solids.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_composites.py

Loading...
View Options

python_modules/dagster/dagster/cli/pipeline.py

Loading...
View Options

python_modules/dagster/dagster/core/host_representation/pipeline_index.py

Loading...
View Options

python_modules/dagster/dagster/core/host_representation/represented.py

Loading...
View Options

python_modules/dagster/dagster/core/snap/pipeline_snapshot.py

Loading...
View Options

python_modules/dagster/dagster/core/snap/solid.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/graph_tests/test_graph.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/snap_tests/test_pipeline_snap.py

Loading...