added test
Details
Details
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| python_modules/dagster/dagster_tests/core_tests/graph_tests/test_graph.py | ||
|---|---|---|
| 249–251 | ^ looking for feedback here | |
Comment Actions
Do you have thoughts on what the dagit experience should be like? I.e. where does graph description vs. job description show up?
Comment Actions
Im not sure. I think the graph page having the graph desc is clear.
I could see the job page showing both (hiding when None) which would imply not inheriting
I could see the job page just showing just job desc which would support inheriting.
Should we start here without and change it to add later based on dagit iteration?
| python_modules/dagster/dagster_tests/core_tests/graph_tests/test_graph.py | ||
|---|---|---|
| 251 | My intuition would be that we would default to the graph's desc, and the desc arg on to_job would act as an override almost. | |
| python_modules/dagster/dagster_tests/core_tests/graph_tests/test_graph.py | ||
|---|---|---|
| 251 | that behavior does align with name | |
Comment Actions
I think its a reasonable approach to land this and change the defaulting-from-graph behavior later if we decide its the right thing to do