Move serdes deserialization out of DagsterGrpcClient
ClosedPublic
Actions

Authored by • dgibson on Jul 19 2021, 1:31 PM.

Details

Reviewers

alangenfeld
• max
• johann

Commits

R1:c192b5d6c9cd: Move serdes deserialization out of DagsterGrpcClient

Summary

Doing this in the callsite instead gives us more flexibility with back-compat, since we might just want to pass through the results of a gRPC client in some contexts without deserializing it.

Test Plan

Diff Detail

Repository

R1 dagster

Branch

grpcompat (branched from master)

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

• dgibson created this revision.Jul 19 2021, 1:31 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 19 2021, 1:53 PM

Harbormaster failed remote builds in B33838: Diff 41793!

• dgibson published this revision for review.Jul 19 2021, 2:14 PM

Harbormaster completed remote builds in B33839: Diff 41794.Jul 19 2021, 2:36 PM

• dgibson added reviewers: • max, • johann.Jul 19 2021, 5:05 PM

• max accepted this revision.Jul 19 2021, 9:59 PM

This revision is now accepted and ready to land.Jul 19 2021, 9:59 PM

Closed by commit R1:c192b5d6c9cd: Move serdes deserialization out of DagsterGrpcClient (authored by • dgibson). · Explain WhyJul 19 2021, 10:00 PM

This revision was automatically updated to reflect the committed changes.

• dgibson added a commit: R1:c192b5d6c9cd: Move serdes deserialization out of DagsterGrpcClient.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

api/

list_repositories.py

4 lines

snapshot_execution_plan.py

23 lines

snapshot_partition.py

49 lines

snapshot_pipeline.py

9 lines

snapshot_schedule.py

27 lines

snapshot_sensor.py

21 lines

core/

host_representation/

repository_location.py

7 lines

launcher/

default_run_launcher.py

28 lines

grpc/

client.py

50 lines

types.py

4 lines

dagster_tests/

api_tests/

test_api_launch_run.py

39 lines

test_api_list_repositories.py

6 lines

general_tests/

grpc_tests/

test_persistent.py

9 lines

Diff 41794

View Options

python_modules/dagster/dagster/api/list_repositories.py

View Options

python_modules/dagster/dagster/api/snapshot_execution_plan.py

View Options

python_modules/dagster/dagster/api/snapshot_partition.py

View Options

python_modules/dagster/dagster/api/snapshot_pipeline.py

View Options

python_modules/dagster/dagster/api/snapshot_schedule.py

View Options

python_modules/dagster/dagster/api/snapshot_sensor.py

View Options

python_modules/dagster/dagster/core/host_representation/repository_location.py

View Options

python_modules/dagster/dagster/core/launcher/default_run_launcher.py

View Options

python_modules/dagster/dagster/grpc/client.py

View Options

python_modules/dagster/dagster/grpc/types.py

View Options

python_modules/dagster/dagster_tests/api_tests/test_api_launch_run.py

View Options

python_modules/dagster/dagster_tests/api_tests/test_api_list_repositories.py

View Options

python_modules/dagster/dagster_tests/general_tests/grpc_tests/test_persistent.py

Move serdes deserialization out of DagsterGrpcClientClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41794

python_modules/dagster/dagster/api/list_repositories.py

python_modules/dagster/dagster/api/snapshot_execution_plan.py

python_modules/dagster/dagster/api/snapshot_partition.py

python_modules/dagster/dagster/api/snapshot_pipeline.py

python_modules/dagster/dagster/api/snapshot_schedule.py

python_modules/dagster/dagster/api/snapshot_sensor.py

python_modules/dagster/dagster/core/host_representation/repository_location.py

python_modules/dagster/dagster/core/launcher/default_run_launcher.py

python_modules/dagster/dagster/grpc/client.py

python_modules/dagster/dagster/grpc/types.py

python_modules/dagster/dagster_tests/api_tests/test_api_launch_run.py

python_modules/dagster/dagster_tests/api_tests/test_api_list_repositories.py

python_modules/dagster/dagster_tests/general_tests/grpc_tests/test_persistent.py

Move serdes deserialization out of DagsterGrpcClient
ClosedPublic
Actions

Revision Contents
Changeset List