Page MenuHomeElementl

[memoization improvements 2/n] allow dagster execution with no steps.
ClosedPublic

Authored by cdecarolis on Jul 16 2021, 3:51 PM.

Details

Summary

Currently, we fail fast (and in different ways) when attempting to execute with no step keys. This unifies the meaning of empty step keys across the system: step_keys_to_execute=None means execute all steps, step_keys_to_execute=[] means empty steps.

Test Plan

Fix all tests to make sure that this is the case.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 16 2021, 4:15 PM
Harbormaster failed remote builds in B33805: Diff 41748!
cdecarolis retitled this revision from allow dagster execution with no steps. to [memoization improvements 2/n] allow dagster execution with no steps..Jul 16 2021, 9:26 PM

feels like there should be a few more tests but im struggling to think of what cases make sense to test. reexecute_pipeline with explicit empty step selection?

python_modules/dagster/dagster_tests/core_tests/execution_tests/test_memoized_dev_loop.py
57–100

nit: some comments explaining whats happening here - the test case name doesnt tell you much

This revision is now accepted and ready to land.Jul 20 2021, 8:01 PM

feels like there should be a few more tests but im struggling to think of what cases make sense to test. reexecute_pipeline with explicit empty step selection?

that, maybe similar for create_run as well

Add description to dev loop tests