Page MenuHomeElementl

[dagit] Upgrade chart.js
ClosedPublic

Authored by dish on Jul 16 2021, 3:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Feb 6, 8:54 PM
Unknown Object (File)
Sat, Jan 14, 11:53 AM
Unknown Object (File)
Jan 3 2023, 6:24 PM
Unknown Object (File)
Dec 16 2022, 2:54 PM
Unknown Object (File)
Nov 18 2022, 1:17 AM
Unknown Object (File)
Nov 18 2022, 1:17 AM
Unknown Object (File)
Nov 18 2022, 1:16 AM
Unknown Object (File)
Nov 14 2022, 6:53 PM
Subscribers
None

Details

Summary

Upgrade chart.js to v3, which allows us to get past an existing security issue with v2 that makes it much harder to implement a CSP in internal, namely that v2 would require us to enable unsafe-inline.

This required changing some options objects for v3, but I think I did it correctly. It would be good to bang away at this in dev to make sure that the charts are all behaving as expected.

Test Plan

View charts in Dagit, interact with them. Verify that things seem to be working normally, including:

  • Zoom/pan behavior in tick history
  • Hover/tooltip behavior

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This looks good to me! +1 for merging and kicking the tires on dev.

This revision is now accepted and ready to land.Jul 16 2021, 4:03 PM
This revision was automatically updated to reflect the committed changes.