Page MenuHomePhabricator

Fix errors for repositories without scheduler
ClosedPublic

Authored by sashank on Aug 27 2019, 9:58 PM.

Details

Reviewers
nate
Group Reviewers
Restricted Project
Commits
R1:65a110c63b17: Fix errors for repositories without scheduler
Summary

If a repository didn't have a scheduler defined and the SCHEDULER feature flag was enabled, an error would be thrown because scheduler_type would be the abc Scheduler. This diff replaces the get_scheduler_type method on RepositoryDefinition with build_scheduler, which checks whether scheduler_type is defined and instantiates the scheduler if it is.

Test Plan

unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sashank created this revision.Aug 27 2019, 9:58 PM
nate accepted this revision.Aug 27 2019, 11:34 PM
This revision is now accepted and ready to land.Aug 27 2019, 11:34 PM