Page MenuHomeElementl
Differential D8919

Pass in an instance ref to daemon run loop rather than using DagsterInstance.get()
ClosedPublic
Actions

Authored by • dgibson on Jul 16 2021, 1:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 27, 2:03 AM
Unknown Object (File)
Nov 18 2022, 1:16 AM
Unknown Object (File)
Nov 18 2022, 1:16 AM
Unknown Object (File)
Nov 18 2022, 1:16 AM
Unknown Object (File)
Nov 15 2022, 5:36 PM
Unknown Object (File)
Nov 14 2022, 6:49 PM
Unknown Object (File)
Nov 13 2022, 11:20 AM
Unknown Object (File)
Nov 11 2022, 1:30 AM
View All 32 Files
Subscribers
None

Details

Reviewers
alangenfeld
• jordansanders
• johann
• rexledesma
Commits
R1:286983e3e105: Pass in an instance ref to daemon run loop rather than using DagsterInstance.
Summary

This lets us pass through scoped instance refs into daemon threads in the event that we allow you to create scoped instances.

Test Plan

Integration

Diff Detail

Repository
R1 dagster
Branch
daemonref (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
daemon/
1 line
3 lines
dagster_tests/
daemon_tests/
1 line

Diff 41728

View Options

python_modules/dagster/dagster/daemon/controller.py

Loading...
View Options

python_modules/dagster/dagster/daemon/daemon.py

Loading...
View Options

python_modules/dagster/dagster_tests/daemon_tests/test_sensor_run.py

Loading...