Page MenuHomeElementl
Differential D8919

Pass in an instance ref to daemon run loop rather than using DagsterInstance.get()
ClosedPublic
Actions

Authored by • dgibson on Jul 16 2021, 1:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 7, 10:38 AM
Unknown Object (File)
Sun, May 7, 3:40 AM
Unknown Object (File)
Apr 27 2023, 6:06 PM
Unknown Object (File)
Mar 29 2023, 12:31 AM
Unknown Object (File)
Mar 21 2023, 8:35 AM
Unknown Object (File)
Mar 16 2023, 10:38 PM
Unknown Object (File)
Mar 10 2023, 10:48 PM
Unknown Object (File)
Feb 13 2023, 2:48 AM
View All 42 Files
Subscribers
None

Details

Reviewers
alangenfeld
• jordansanders
• johann
• rexledesma
Commits
R1:286983e3e105: Pass in an instance ref to daemon run loop rather than using DagsterInstance.
Summary

This lets us pass through scoped instance refs into daemon threads in the event that we allow you to create scoped instances.

Test Plan

Integration

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
daemon/
1 line
3 lines
dagster_tests/
daemon_tests/
1 line

Diff 41730

View Options

python_modules/dagster/dagster/daemon/controller.py

Loading...
View Options

python_modules/dagster/dagster/daemon/daemon.py

Loading...
View Options

python_modules/dagster/dagster_tests/daemon_tests/test_sensor_run.py

Loading...